This question especially goes to the non-Americans for a non-biased perspective. Feel free to answer anyways, just make sure to mention that you're American if you do.
California, easily. No competition.
I'd say Texas is #2.
Definitely not New York, because it's mostly known for New York City, not the state.
Not Florida either.
I mean the number of songs about California alone:
Hotel California
California Calling
California Gurls
California King Bed (sorta)
California Dreaming
Gone to California (Pink)
Dani California
Californication
California Love (2Pac)
I'm not American. I think it's all the accent, cowboy and western stuff, and it's generally just very well known in terms of iconism. I'd also argue for Hawaii, New Jersey, and California, I guess.
But for NY I would say it's more for the city than the state, no?